Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

Input with long placeholder doesn't get cut off #1419

Closed
ilanbiala opened this issue Feb 7, 2015 · 6 comments
Closed

Input with long placeholder doesn't get cut off #1419

ilanbiala opened this issue Feb 7, 2015 · 6 comments

Comments

@ilanbiala
Copy link
Contributor

With regular inputs that have a placeholder that doesn't fit in the input, the placeholder gets chopped off. With ngMaterial, the placeholder continues to wander outside of the input.

screen shot 2015-02-06 at 7 20 48 pm

@marcysutton
Copy link
Contributor

We'd love to see PRs that fix these kinds of issues.

@ilanbiala
Copy link
Contributor Author

@marcysutton can you point me to the HTML code for the md-input-container and I'll try to see what's the issue.

@ilanbiala
Copy link
Contributor Author

@marcysutton I took a look at the JS, HTML, and CSS, and it seems that adding overflow-x: hidden to the md-input-container fixes it and doesn't cause other issues. You may want to do more testing to see if it causes any issues I didn't notice.

@marcysutton
Copy link
Contributor

@ilanbiala seems easy enough for a PR, want to take a crack at it?

@ilanbiala
Copy link
Contributor Author

@marcysutton not really sure what else there is to it, but at least the PR is a start.

@ilanbiala ilanbiala changed the title Input with placeholder longer doesn't get cut off Input with long placeholder doesn't get cut off Feb 12, 2015
@ilanbiala
Copy link
Contributor Author

@marcysutton have you had a chance to look at the PR? It's just the fix I suggested above. I don't think it breaks any compatibility with other parts of the component.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants