Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

md-tabs and md-sidenav are incompatible with fastclick #1448

Closed
infomofo opened this issue Feb 10, 2015 · 3 comments
Closed

md-tabs and md-sidenav are incompatible with fastclick #1448

infomofo opened this issue Feb 10, 2015 · 3 comments
Milestone

Comments

@infomofo
Copy link

I tried integrating fastclick into my material-angular application, to deal with the bug described on the angular issue tracker where ng-click events can fire twice on mobile applications. However, when I turned fastclick on, I found a few issues with some of the core angular material directives on mobile devices. For example, tabs stopped responding to touch events (the ink ripples would fire, but they wouldn't switch tabs). Also, the sidenav would no longer dismiss from a touch event outside the nav.

@ThomasBurleson ThomasBurleson modified the milestone: 0.9.0 Feb 17, 2015
@robertmesserle robertmesserle self-assigned this Mar 12, 2015
@robertmesserle robertmesserle modified the milestones: 0.10.0, 0.9.0 Mar 24, 2015
@robertmesserle robertmesserle modified the milestones: 0.10.0, Backlog Jun 10, 2015
@robertmesserle robertmesserle modified the milestones: post-1.0 , Backlog Aug 4, 2015
@roidayan
Copy link

I got different behavior from described when using fastclick. the sidenav is being dismissed on touch outside but ripple effects are not shown anymore.

@ThomasBurleson ThomasBurleson modified the milestones: post-1.0 , Backlog Jan 5, 2016
@ThomasBurleson ThomasBurleson modified the milestones: Backlog, Deprecated Apr 20, 2016
@dantaylor
Copy link

was there any updates on that @roidayan ? I am getting the same behavior. Basically all elements that had ripples no longer show the ripples after fastclick, I wish there was a way to remove the 300ms delay and still preserve the ripple ink effect. I wonder if the ripple directive is tied to a subsequent click event or bubble that is getting canceled by fast click?
For the time being it seems more valuable to have a snappier ux than it is to have ripples :-/

@roidayan
Copy link

not really tracking. checking my project i see i still use fastclick. i dont see ripple effect on sidenav click but it's fine. as you said snappier ux is better and I really don't think about the ripples.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants