Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

update(icon): added unit test to ensure error when icon or set not found #1477

Closed
wants to merge 1 commit into from
Closed

update(icon): added unit test to ensure error when icon or set not found #1477

wants to merge 1 commit into from

Conversation

programmist
Copy link
Contributor

No description provided.

@ajoslin ajoslin added the in progress Mainly for in progress PRs, but may be used for issues that require multiple PRs label Feb 12, 2015
@googlebot
Copy link

Thanks for your pull request.

It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at https://cla.developers.google.com/.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check the information on your CLA or see this help article on setting the email on your git commits.

Once you've done that, please reply here to let us know. If you signed the CLA as a corporation, please let us know the company's name.

@programmist
Copy link
Contributor Author

Sorry. Somehow I managed to close my other PR.

@programmist
Copy link
Contributor Author

Updated PR with more tests. Also split directive and service tests into separate files.

@ThomasBurleson ThomasBurleson removed the in progress Mainly for in progress PRs, but may be used for issues that require multiple PRs label Feb 13, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@programmist @googlebot @ThomasBurleson @ajoslin