Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

Allow demos to be modified #1489

Closed
ilanbiala opened this issue Feb 12, 2015 · 13 comments
Closed

Allow demos to be modified #1489

ilanbiala opened this issue Feb 12, 2015 · 13 comments
Assignees
Labels
for: internal contributor The team will address this issue and community PRs are not requested. type: build type: demos type: enhancement
Milestone

Comments

@ilanbiala
Copy link
Contributor

It would be awesome to just modify the demos instead of having to work through CodePen or Plunker and play with the really simple code.

@ThomasBurleson
Copy link
Contributor

@ilanbiala - Perhaps you could help us make CodePens corresponding to each of our demos... ?

@ilanbiala
Copy link
Contributor Author

@ThomasBurleson instead of keeping CodePens and docs up-to-date, why not just have the code sample be modify-able or just make the demos use a CodePen. Minimize the amount of work necessary to keep docs up-to-date.

@marcysutton
Copy link
Contributor

We do plan to have "runnable examples" like on docs.angularjs.org. I agree that making them dynamic somehow will help keep things up to date. But planning & implementing that is not an easy task.

@ilanbiala
Copy link
Contributor Author

@marcysutton if you guys want, I can work on a PR for that.

@marcysutton
Copy link
Contributor

By all means, go ahead and work on a PR for the demos. Please just keep the docs information architecture/navigation structure intact.

@gkalpak
Copy link
Member

gkalpak commented Feb 13, 2015

BTW, the runnable examples in docs.angularjs.org (that @marcysutton mentioned above) are creating a new plunkr on the fly (when you click the "Edit in plunkr" button).

If anyone is interested in taking a look at how this is accomplished, the relevant code is here.
(Not sure if CodePen supports something similar.)

@marcysutton
Copy link
Contributor

We chose Codepen primarily because it's more accessible. Looks like you can prefill using their API: http://blog.codepen.io/documentation/api/prefill/

@gkalpak
Copy link
Member

gkalpak commented Feb 13, 2015

All good then :)
👍 on using CodePen (I don't know about accessiblity, but it has the most mobile-friendly design) !

@marcysutton
Copy link
Contributor

@ilanbiala are you still working on a PR for this?

@ilanbiala
Copy link
Contributor Author

@marcysutton I actually have an instant HTML + CSS + JS editor already on another site that I can port into a PR that renders the results. Is that something you guys are interested in?

@marcysutton
Copy link
Contributor

The request is for automated Codepen demos so that they can be easily forked. Similar to how docs.angularjs.org will allow you to create a Plunker right from the docs, except Codepen has better accessibility and platform features.

@matthewrfindley
Copy link
Contributor

Examples on the documentation site are now editable via codepen. As of 5c37dc8, users will be able to click the 'Edit on Codepen' button to create a copy of the example on Codepen.

@marcysutton
Copy link
Contributor

YAY! Hi-five!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
for: internal contributor The team will address this issue and community PRs are not requested. type: build type: demos type: enhancement
Projects
None yet
Development

No branches or pull requests

5 participants