Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

feat(script): Set ngModule to Closure namespace. #1709

Closed
wants to merge 1 commit into from

Conversation

wesalvaro
Copy link
Contributor

When using Closure, it is common to reference Angular module dependencies by the name property of the module.
This looks like:

goog.provide('bar.module');
goog.require('foo.module');
bar.module = angular.module('bar.module', [foo.module.name]);

This change makes it possible for this kind of reference instead of having to refer to the dependent module as a string.

@googlebot
Copy link

Thanks for your pull request.

It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at https://cla.developers.google.com/.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check the information on your CLA or see this help article on setting the email on your git commits.

Once you've done that, please reply here to let us know. If you signed the CLA as a corporation, please let us know the company's name.

When using Closure, it is common to reference Angular module
dependencies by the name property of the module.
This looks like:
```
goog.provide('bar.module');
goog.require('foo.module');
bar.module = angular.module('bar.module', [foo.module.name]);
```
This change makes it possible for this kind of reference instead of
having to refer to the dependent module as a string.
@googlebot
Copy link

CLAs look good, thanks!

@jelbourn
Copy link
Member

jelbourn commented Mar 2, 2015

Look good to me.

@wesalvaro wesalvaro deleted the patch-2 branch May 11, 2015 13:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants