This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
fix(runHandlers): check if handler returned is not undefined #2074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runHandlers performs a for in loop to retrieve all properties, but does not check
it HANDLERS contains a handler with that key - which breaks if user code extends
Object.
fixes angular#2072
|
travis checks failed due to github issues: fatal: unable to connect to github.com: But I dont figure how to trigger retry |
JulianWielga
pushed a commit
to JulianWielga/material
that referenced
this pull request
Apr 1, 2015
Also resolve ::runHandlers RTE when Object.prototypes are extended. Closes angular#2074. Closes angular#2072. Closes angular#1791
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2072