This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
fix(list): add ripple, inherit from .md-button #2395
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates interaction styles of list controls to attach ripple on click of list items with proxy controls, and makes child primary & secondary icon buttons into md-button. This allows for correct dimensions and mouse/focus behavior to be extended to list controls.
ajoslin
added
the
in progress
|
The click on the switch does not ripple the row... yet the checkbox-click does. Bug ? |
|
I really like this UX now. |
| @@ -189,6 +198,8 @@ function mdListItemDirective($mdAria, $mdConstant) { | |||
| function computeClickable() { | |||
| if (proxies.length || $element[0].firstElementChild.hasAttribute('ng-click')) { | |||
| $element.addClass('md-clickable'); | |||
|
|
|||
| ctrl.attachRipple($scope, angular.element($element[0].querySelector('.md-no-style'))); | |||
There was a problem hiding this comment.
Why .md-clickable and .attachRipple() ?
There was a problem hiding this comment.
I think the only thing .md-clickable does is add the pointer cursor in CSS.
|
The "Clickable Items with Secondary Controls" demo shows the switch as a secondary item, so it wouldn't highlight the whole row on click. It contrasts with the first controls demo, where the checkbox is the only action, and it can be toggled by clicking on the row. |
ajoslin
removed
the
in progress
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates interaction styles of list controls to attach ripple on click of list items with proxy controls, and makes child primary & secondary icon buttons into
md-buttonelements. This allows for correct icon button dimensions and mouse/focus behavior to be extended to list controls.