-
Notifications
You must be signed in to change notification settings - Fork 3.4k
fix(select): fix cycle option focus after keyboard search #2616
Conversation
After keyboard search option focus cycling would start from previously focused element
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
@googlebot Added primary Github email to CLA. |
Search would not work properly with duplicate keydown listeners
@brandom - You need to sign a CLA for account also. |
@ThomasBurleson The first commit that did not pass was accidentally committed under my work email address. I just added the email address to my Github account as well as the CLA. Do I need to create another PR or will @googlebot pick this up? |
CLAs look good, thanks! |
@rschmukler - can you review this? |
@brandom LGTM, merged! Thanks!! |
@rschmukler Thanks! This branch has another commit for the same component that was not merged. Was this intentional? |
@rschmukler Odd, github says the branch has unmerged commits and I only see 3e3eb9e in this thread. However clicking the link for cc8850b proves this is not the case so carry on 👍 |
After keyboard search option focus cycling would start from previously focused element