This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
feat(autocomplete): adds support for ng-messages #2664
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: `name` attribute has been changed to `input-name` to more clearly show its purpose
ajoslin
added
the
in progress
|
@ThomasBurleson This is not ready to be merged, but I wanted to get some eyes on it. There are also some confusing parts here that I'd like to discuss on Monday regarding validation. |
ThomasBurleson
removed
the
in progress
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:
nameattribute has been changed toinput-nametomore clearly show its purpose