Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

md-3-line should align icons to the top IF ng-click is added #3054

Closed
asans opened this issue May 31, 2015 · 2 comments
Closed

md-3-line should align icons to the top IF ng-click is added #3054

asans opened this issue May 31, 2015 · 2 comments
Assignees
Labels
needs: demo A CodePen demo or GitHub repository is needed to demonstrate the reproduction of the issue ui: CSS
Milestone

Comments

@asans
Copy link

asans commented May 31, 2015

The fix for #2589 does not fully fix the issue of top-aligning icons. The current fix only addresses the issue when the md-list-item is not clickable.

If and when one adds ng-click or ng-href to create a clickable list item, the style is no longer applied.

This is due to the following code:

a2b88be#diff-c3e997633bc56157521f1305098d447aL199

The selector:

   > md-icon:first-child {

Which only selects the immediate child of md-list-item. When ng-click is applied to md-list-item, there's an intermediate button injected into the system, causing the new style not to be selected.

@ThomasBurleson ThomasBurleson modified the milestone: Backlog Jul 6, 2015
@ThomasBurleson ThomasBurleson modified the milestones: Backlog, 0.12.0 Sep 2, 2015
@topherfangio topherfangio modified the milestones: 0.12, 0.13 Oct 15, 2015
@ThomasBurleson ThomasBurleson modified the milestones: 1.0-rc2, 1.0-rc3 Oct 30, 2015
@topherfangio topherfangio added the needs: demo A CodePen demo or GitHub repository is needed to demonstrate the reproduction of the issue label Nov 3, 2015
@topherfangio
Copy link
Contributor

Is there any chance you could provide a demo using the latest code so we can see if this is still an issue?

@topherfangio topherfangio modified the milestones: 1.0-rc6, 1.0-rc3 Nov 3, 2015
@topherfangio
Copy link
Contributor

We really need a demo to investigate this further. Please provide a Codepen and we will reopen.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs: demo A CodePen demo or GitHub repository is needed to demonstrate the reproduction of the issue ui: CSS
Projects
None yet
Development

No branches or pull requests

3 participants