This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
mdMenu - a menu component - wip PR #3173
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
| @@ -0,0 +1,111 @@ | |||
| /** | |||
There was a problem hiding this comment.
Any reason for the naming convention of _menu?
There was a problem hiding this comment.
ensure that it gets concatenated first by the build, important because it defines the module
rschmukler
force-pushed
the
wip-menu
branch
2 times, most recently
from
71bad11
to
bb82212
Compare
| * additional options within the context of an action. | ||
| * | ||
| * Every `md-menu` must specify exactly two child elements. The first element is what is | ||
| * left in the DOM and is used to open the menu. This element is called the origin element. |
There was a problem hiding this comment.
I would use the term trigger over origin
| alignTarget = alignTarget.querySelector('[md-menu-align-target]') || alignTarget; | ||
| alignTargetRect = alignTarget.getBoundingClientRect(); | ||
|
|
||
| var containerNodeStyle = $window.getComputedStyle(containerNode); |
There was a problem hiding this comment.
getComputedStyle is pretty expensive; how frequently does this get called?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.