<md-menu> only close with md-button with ng-click, need to be same with ng-href

[alanpurple]

md-menu-item
md-button ng-href="/user-info">Edit User Info</md-button
/md-menu-item>

currently this needs to be

md-menu-item>
md-button ng-click="" ng-href="/user-info">Edit User Info</md-button
/md-menu-item>

make ng-href works same as ng-click, doesn't this look natural?

[epelc]

If this is a problem I'd suspect ui-sref has the same issue.

[hthetiot]

The current implementation can also lead to following JS error.

Uncaught TypeError: target.hasAttribute is not a function

Caused by the function that is trigger when you close the menu.

 do {
-   if (target && target.hasAttribute('ng-click')) {
+   if (target && target.nodeType == 1 && target.hasAttribute('ng-click')) {
      if (!target.hasAttribute('disabled')) {
        close();
      }
      break;
    }
- } while ((target = target.parentNode) && target != opts.menuContentEl)
+ } while ((target = target.parentNode) && target != opts.menuContentEl[0])

[arusakov]

@hthetiot
Faced with the same problem! Create PR. Why "target.nodeType == 1" there?

[thomasbertet]

👍 Faced this issue. I'm using ui-sref / ng-href.

Maybe a copepen could help : http://codepen.io/anon/pen/yNPOBV

-> Click on the first "Redial" menu item, and see the error thrown.

[xtiggerk]

There is also a problem using 'data-ng-click' instead of 'ng-click'. Actually it doesn't work with 'data' prefix (FF and Chrome), works fine with ng-click.

[lrondanini]

same problem here! any suggestion?

[bvolders]

same problem here, can this be fixed ?

[dani3l]

+1 with ui-router

[diegolaciar]

+1 with ui-router ui-sref

[spock123]

// deleted, sorry guys my bad