Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

mdTabs: md-input-container leaks watchers #3508

Closed
jmcpeak opened this issue Jun 30, 2015 · 4 comments
Closed

mdTabs: md-input-container leaks watchers #3508

jmcpeak opened this issue Jun 30, 2015 · 4 comments
Assignees
Labels
severity: memory leak Issues where a memory leak is triggered. type: bug
Milestone

Comments

@jmcpeak
Copy link

jmcpeak commented Jun 30, 2015

Watch count increases every time you change a tab with a md-input-container - tabs 1 and 2

This behaviour is not seen if you use a md-button - tabs 3 and 4

http://codepen.io/jmcpeak/pen/mJpvXg

    <md-tabs>
      <md-tab label="1">
        <md-content>
          <md-input-container>
            <label>1</label>
            <input>
          </md-input-container>
        </md-content>
      </md-tab>
      <md-tab label="2">
        <md-content>
          <md-input-container>
            <label>2</label>
            <input>
          </md-input-container>
        </md-content>
      </md-tab>
    </md-tabs>
  </md-content>
@jmcpeak
Copy link
Author

jmcpeak commented Jun 30, 2015

Hmmm, tab change seems to new a controller every time...

http://codepen.io/jmcpeak/pen/LVeqaX

@ThomasBurleson ThomasBurleson self-assigned this Jul 6, 2015
@ThomasBurleson ThomasBurleson modified the milestone: Backlog Jul 6, 2015
@andreialecu
Copy link

+1, this results in huge leaks in only moderately complex forms, when the workflow consists of switching semi-often between tabs.

@rgolea
Copy link

rgolea commented Jul 12, 2015

+1

@piyushchauhan2011
Copy link

👍

@ThomasBurleson ThomasBurleson added type: bug type: component severity: memory leak Issues where a memory leak is triggered. labels Jul 30, 2015
@ThomasBurleson ThomasBurleson modified the milestones: 0.11.0, Backlog Jul 30, 2015
@ThomasBurleson ThomasBurleson changed the title md-input-container leaks watchers mdTabs: md-input-container leaks watchers Jul 30, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
severity: memory leak Issues where a memory leak is triggered. type: bug
Projects
None yet
Development

No branches or pull requests

6 participants