This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
feat(virtualRepeat): Add md-auto-shrink and md-auto-shrink-min #3536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| scope.$apply(); | ||
| expect(container[0].offsetHeight).toBe(2 * ITEM_SIZE); | ||
| }); | ||
|
|
There was a problem hiding this comment.
No test with md-horizontal and md-auto-shrink-min ?
There was a problem hiding this comment.
Added one. Does not test any new code paths though.
|
LGTM |
kseamon
force-pushed
the
virtual-repeat-container-auto-shrink
branch
from
4fb4025 to
efde978
Compare
review stuff review 2
kseamon
force-pushed
the
virtual-repeat-container-auto-shrink
branch
from
efde978 to
254d7fd
Compare
|
Pushed an update with the comments addressed. |
kseamon
added a commit
that referenced
this pull request
Jul 4, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These attributes instruct the container to shrink to fit when the total size of repeated items is smaller than the available space. This will unblock integration with md-autocomplete.