This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
fix(mdDialog): if targetEvent element is hidden when dialog closes, shrink to the element's original position #3555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hrink to the element's original position Previously the dialog would always shrink to the upper left if the targetEvent element was no longer visible when the dialog closed. Also add tests to verify that the correct CSS transforms are set when expanding and shrinking.
…hrink to the element's original position Previously the dialog would always shrink to the upper left if the targetEvent element was no longer visible when the dialog closed. Also add tests to verify that the correct CSS transforms are set when expanding and shrinking.
…hrink to the element's original position Previously the dialog would always shrink to the upper left if the targetEvent element was no longer visible when the dialog closed. Also add tests to verify that the correct CSS transforms are set when expanding and shrinking.
|
This is a fix for #3541 |
dozingcat
changed the title
|
@dozingcat - can you provide a unit test case or a CodePen to validate these changes? |
|
The codepen at http://codepen.io/anon/pen/BNYpEZ shows the current behavior. This is the local file I used to confirm the new behavior: <html>
<head>
<link rel="stylesheet" href="../material/dist/angular-material.css">
<script src="https://ajax.googleapis.com/ajax/libs/angularjs/1.4.1/angular.min.js"></script>
<script src="https://ajax.googleapis.com/ajax/libs/angularjs/1.4.1/angular-animate.min.js"></script>
<script src="https://ajax.googleapis.com/ajax/libs/angularjs/1.4.1/angular-aria.min.js"></script>
<script src="../material/dist/angular-material.js"></script>
<style>
.menu {
background: lightblue;
}
.menu-contents {
display: none;
padding: 10px;
}
.menu:hover .menu-contents {
display: block;
}
md-dialog {
padding: 20px;
}
</style>
<script>
angular
.module('demoApp', ['ngMaterial'])
.controller("DemoController", function($scope, $mdDialog) {
$scope.showDialog = function(e) {
$mdDialog.show({
template: "<md-dialog>Event: " + e + "</md-dialog>",
clickOutsideToClose: true,
targetEvent: e
})
};
}
);
</script>
</head>
<body>
<div ng-app="demoApp"
ng-controller="DemoController"
style="float:right; padding: 20px;">
<md-button ng-click="showDialog($event)">Open dialog</md-button>
<p></p>
<div class="menu">
Menu
<div class="menu-contents">
<a ng-click="showDialog($event)">Open from menu</a>
</div>
</div>
</div>
</body>
</html> |
|
@dozingcat - that was helpful; and the demo helps me understand a usage scenario. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.