Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

fix(select): interimElement will resolve its promise even when #3794

Closed
wants to merge 1 commit into from
Closed

fix(select): interimElement will resolve its promise even when #3794

wants to merge 1 commit into from

Conversation

robertmesserle
Copy link
Contributor

transition end event is not fired

Closes #3704

@robertmesserle
Copy link
Contributor Author

@ThomasBurleson Wanted you to look over this before merging in.

@robertmesserle
Copy link
Contributor Author

@ThomasBurleson I may spend some time over the weekend looking into a more proper fix for this, so we should probably hold off until Monday to merge it - but it should be fine to merge either way.

@ThomasBurleson
Copy link
Contributor

This looks good (and in hindsight so obvious). Now:

  • show() and remove() use .finally().
  • dialogPopOut. Select, and menu-interim-element use .finally

@EladBezalel EladBezalel deleted the bugs/3704 branch January 15, 2016 22:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robertmesserle @ThomasBurleson