Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

md-select role should be listbox #3859

Closed
calebegg opened this issue Jul 22, 2015 · 2 comments
Closed

md-select role should be listbox #3859

calebegg opened this issue Jul 22, 2015 · 2 comments
Assignees
Labels
a11y This issue is related to accessibility g3: reported The issue was reported by an internal or external product team.
Milestone

Comments

@calebegg
Copy link
Member

md-select has an ARIA role of "combobox", but it's not actually a combobox; it's a listbox. A combobox has a text field for the user to type in new items.

A presentation of a select; usually similar to a textbox where users can type ahead to select an option, or type to enter arbitrary text as a new item in the list.

-- http://www.w3.org/TR/wai-aria/roles#combobox

A combobox is required to have a child element that has role "textbox".

I think listbox is more appropriate:

A widget that allows the user to select one or more items from a list of choices.

-- http://www.w3.org/TR/wai-aria/roles#listbox

@cleever
Copy link

cleever commented Jul 22, 2015

I Agree.

Combobox is appropriate to md-autocomplete.

md-select is other thing, maybe a listbox.

@ThomasBurleson ThomasBurleson added the needs: review This PR is waiting on review from the team label Jul 31, 2015
@ThomasBurleson ThomasBurleson modified the milestone: REVISIT Jul 31, 2015
@ThomasBurleson ThomasBurleson modified the milestones: REVISIT, Backlog Aug 10, 2015
@ThomasBurleson ThomasBurleson added a11y This issue is related to accessibility and removed needs: review This PR is waiting on review from the team labels Sep 4, 2015
@ThomasBurleson ThomasBurleson modified the milestones: 0.12.0, Backlog Sep 4, 2015
@jelbourn jelbourn added the g3: reported The issue was reported by an internal or external product team. label Sep 14, 2015
@marcysutton
Copy link
Contributor

After talking this over with an accessibility colleague of mine and doing some testing, I have found that the role of combobox is actually correct for JAWS and NVDA–that is what is announced for a native select. In VoiceOver on OSX, a native select is announced as "popup button", so the role will have to change depending on the user agent. I would prefer to keep the same role for all user agents, but if there is an easy way to swap out the role with minimal side-effects I will go ahead and do it.

I have opened a separate issue, #4977, to track the remaining issues with the combobox role; mainly, that the options are not rendered on page load, throwing an error in multiple accessibility checkers.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a11y This issue is related to accessibility g3: reported The issue was reported by an internal or external product team.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants