Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

md-tabs: controller leakage (1.4.x compatibility) #3975

Closed
YBogomolov opened this issue Jul 31, 2015 · 1 comment
Closed

md-tabs: controller leakage (1.4.x compatibility) #3975

YBogomolov opened this issue Jul 31, 2015 · 1 comment
Assignees
Milestone

Comments

@YBogomolov
Copy link

With Angular 1.4.x ngIf began to work as expected, and this lead to the following issue with md-tabs.

Consider the following CodePen as an example: http://codepen.io/anon/pen/PqXGKB
When you switch between tabs, you can see that in console many new messages 'I am created!' are written, thus many scopes are created, too. But none of them are destroyed.

The fix is relatively simple: you should change ng-if to ng-show in /src/components/tabs/js/tabsDirective.js:193. This will return the old behavior.

@andreialecu
Copy link

This is fixed in the latest 0.10.1-rc5: http://codepen.io/anon/pen/zGyZVZ

Related: #3692

@ThomasBurleson ThomasBurleson added this to the 0.12.0 milestone Aug 20, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants