Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

fix(chips): interaction with Autocomplete #4108

Closed
wants to merge 1 commit into from

Conversation

typotter
Copy link
Contributor

Properly set require-match=true in demos so that the value is correct in the components.
Check for requiredMatch on the controller instead of on the scope.

fixes #3475

Properly set require-match=true in demos so that the value is correct in the components.
Check for requiredMatch on the controller instead of on the scope.

fixes angular#3475
@typotter typotter added the needs: review This PR is waiting on review from the team label Aug 11, 2015
@ThomasBurleson ThomasBurleson modified the milestone: 0.11.0 Aug 14, 2015
@naomiblack naomiblack modified the milestones: 0.12.0, 0.11.0 Aug 14, 2015
@houmark
Copy link

houmark commented Aug 18, 2015

@robertmesserle Now that you are on a PR streak, maybe this one could make it as well? :)

@houmark
Copy link

houmark commented Aug 18, 2015

Thanks a bunch. I tested and it all works well, as long as you make sure to get md-require-match="true" set.

@robertmesserle
Copy link
Contributor

Yea, this is a known issue that I plan to look into (hopefully tomorrow).

On Mon, Aug 17, 2015 at 6:45 PM, houmark notifications@github.com wrote:

Thanks a bunch. I tested and it all works well, as long as you make
sure to get md-require-match="true" set.


Reply to this email directly or view it on GitHub
#4108 (comment).

@houmark
Copy link

houmark commented Aug 18, 2015

It might be my lack of understanding all the potential options and combinations here, but it's still weird behavior for me that not setting md-require-match makes it choose a more or less "random" auto complete option when I hit ENTER, while TAB always works. But this is at least fixing the very worst bug for me, the rest seems more like cleanup and refactoring to get more consistency.

kennethcachia pushed a commit to kennethcachia/material that referenced this pull request Sep 23, 2015
Properly set require-match=true in demos so that the value is correct in the components.
Check for requiredMatch on the controller instead of on the scope.

fixes angular#3475

closes angular#4108
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs: review This PR is waiting on review from the team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chips have blank template when search text not found in items collection
5 participants