Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

$mdSideNav no longer animates in angular 1.4.4 #4152

Closed
hodeyp opened this issue Aug 14, 2015 · 20 comments
Closed

$mdSideNav no longer animates in angular 1.4.4 #4152

hodeyp opened this issue Aug 14, 2015 · 20 comments
Assignees
Labels
hotlist: animations needs: investigation The cause of this issue is not well understood and needs to be investigated by the team or community
Milestone

Comments

@hodeyp
Copy link

hodeyp commented Aug 14, 2015

No description provided.

@julienpa
Copy link

I have the same issue with Angular Material 0.10.1

@brianfeister
Copy link

👍

@ThomasBurleson ThomasBurleson added this to the 0.11.0 milestone Aug 14, 2015
@ThomasBurleson ThomasBurleson self-assigned this Aug 14, 2015
@ThomasBurleson ThomasBurleson added hotlist: angular-issue needs: investigation The cause of this issue is not well understood and needs to be investigated by the team or community hotlist: animations labels Aug 14, 2015
@AleksueiR
Copy link

👍

@nextor2k
Copy link

the animations seem more fluid in angular 1.3.x than in 1.4.x. Anyone else feels like this?

@julienpa
Copy link

@nestorneto although I didn't try with Angular 1.3.x, it's completely possible: ngAnimate was largely re-written in 1.4 and it may have introduced some performance issues for some modules I guess

@ThomasBurleson
Copy link
Contributor

The Angular teams are working on improvements to ngAnimate and request animation frame optimizations. We hope to have these types of perf issues more fully addressed by start of next week.

@julienpa
Copy link

Thanks for the update @ThomasBurleson!

@topherfangio
Copy link
Contributor

@matsko Per your request, here is a codepen demonstrating the problem: http://codepen.io/topherfangio/pen/OVeNym

@hallaji
Copy link

hallaji commented Aug 20, 2015

@topherfangio 👍 I have the same issue too.

@prijindal
Copy link

I think the problem is somewhere in angular-animate 1.4.4
Instead of using 1.4.4 using 1.4.3 resolved my problem

@topherfangio
Copy link
Contributor

Yes, I believe the team is investigating some changes in 1.4.4 that might be causing the issue. It looks like there were quite a few updates, though, so it's possible we need to update the material component too.

Hopefully we'll hear back soon about whether or not it's actually an issue in 1.4.4.

@matsko
Copy link
Contributor

matsko commented Aug 21, 2015

I'm working on a fix right now.

@topherfangio
Copy link
Contributor

Sweet. Thanks @matsko!

@miclaus
Copy link

miclaus commented Aug 25, 2015

Thank you @matsko !

@matsko
Copy link
Contributor

matsko commented Aug 25, 2015

1.4.5 will fix the issue: http://codepen.io/yearofmoo/pen/aOeaYY

@ThomasBurleson
Copy link
Contributor

@matsko - what was the commit that fixed this ?

@matsko
Copy link
Contributor

matsko commented Aug 25, 2015

Not merged into master yet. Waiting for Igor to review angular/angular.js#12669

@Blackmoonx
Copy link

@matsko Is there any ETA for 1.4.5 release?

@matsko
Copy link
Contributor

matsko commented Aug 28, 2015

Later today if all goes smoothly

@Wsiegenthaler
Copy link

Just updated to 1.4.5 and animation is back

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
hotlist: animations needs: investigation The cause of this issue is not well understood and needs to be investigated by the team or community
Projects
None yet
Development

No branches or pull requests