This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
fix(tooltip): Fix md-tooltip showing when window receives focus #4191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mhchen - can you provide a test to accompany these improvements? |
ThomasBurleson
added
needs: tests
in progress
When the parent of an md-tooltip was clicked, it received focus. When the window was blurred and re-focused (e.g. on tab change), the tooltip shows again due to a new focus event firing. This fix prevents this first focus event from having any effect. Note that this bug only affected browsers that focus buttons on click. Fixes #3035
|
@ThomasBurleson Rebased and re-pushed. The md-button module had to be pulled in in order to do actual simulation of the button.focus()/document.activeElement behavior. Because I was able to simulate this behavior (instead of relying on jasmine.mockElementFocus), it seemed like a good time to fix the fragility of the test above it as well. |
|
@mhchen - 👍 |
kennethcachia
pushed a commit
to kennethcachia/material
that referenced
this pull request
Sep 23, 2015
When the parent of an md-tooltip was clicked, it received focus. When the window was blurred and re-focused (e.g. on tab change), the tooltip shows again due to a new focus event firing. This fix prevents this first focus event from having any effect. Note that this bug only affected browsers that focus buttons on click. Fixes angular#3035. Closes angular#4191.
ThomasBurleson
removed
the
in progress
Splaktar
added
the
needs: unit tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the parent of an md-tooltip was clicked, it received focus. When
the window was blurred and re-focused (e.g. on tab change), the tooltip
shows again due to a new focus event firing. This fix prevents this
first focus event from having any effect. Note that this bug only
affected browsers that focus buttons on click.
Fixes #3035