This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
fix(gesture): fix overzealous preventDefault on label+input clicks. #4223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jelbourn - I have encountered similar situations where a custom event was needed, but it would not trigger the handler. While a test would be ideal, I will merge for now... |
kennethcachia
pushed a commit
to kennethcachia/material
that referenced
this pull request
Sep 23, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4110
This change is missing a unit test. After spending quite a bit of time trying to write one, I've been unable to find a way to imitate this browser behavior manually.
Using
label.click()will correctly make the associated input also fire a click event, but the coordinates for both events will be (0, 0), which $mdGesture interprets as a keyboard-triggered click.Manually creating an event and using
label.dispatchEventlets you set the coordinates, but dispatching it in this way does not also automatically trigger a click on the input.@robertmesserle @ThomasBurleson