This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
fix(datepicker): update input size and invalid class on calendar click #4262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also updated a few unit tests involving the invalid class to use the .toHaveClass Jasmine matcher that I should've seen the first time around. |
| self.inputElement.value = self.dateLocale.formatDate(date); | ||
| self.closeCalendarPane(); | ||
| self.resizeInputElement(); | ||
| self.inputContainer.classList.remove(INVALID_CLASS); |
There was a problem hiding this comment.
Would it work if you just called ngModelCtrl.$render here?
There was a problem hiding this comment.
Hm no, it doesn't look like calling $render actually triggers the input handlers
|
LGTM |
kennethcachia
pushed a commit
to kennethcachia/material
that referenced
this pull request
Sep 23, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jelbourn Please review