This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
feat(contactChips): Add md-highlight-flags support. #4278
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@typotter Can you review this super-fast and make sure this is the solution we discussed at the summit? |
|
lgtm, but please add docs for the new parameter to chips. |
Contact Chips currently allows the use of `md-highlight-text` to match the search text. Users have requested we add `md-highlight-flags` as well so that the highlighted text can match the search field parameters. Mainly, if a match is found with case-insensitive search, it would be nice if the highlight text was also case-insensitive. fixes #3182
topherfangio
force-pushed
the
fix-chips-highlight-3182
branch
from
e09eebd
to
c394d43
Compare
topherfangio
added
pr: merge ready
kennethcachia
pushed a commit
to kennethcachia/material
that referenced
this pull request
Sep 23, 2015
Contact Chips currently allows the use of `md-highlight-text` to match the search text. Users have requested we add `md-highlight-flags` as well so that the highlighted text can match the search field parameters. Mainly, if a match is found with case-insensitive search, it would be nice if the highlight text was also case-insensitive. fixes angular#3182. closes angular#4278.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contact Chips currently allows the use of
md-highlight-textto match the search text. Users have requested we addmd-highlight-flagsas well so that the highlighted text can match the search field parameters.Mainly, if a match is found with case-insensitive search, it would be nice if the highlight text was also case-insensitive.
Also, slightly refactor tests.
fixes #3182