Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

fix(mdBottomSheet): Enable touch interaction on mobile devices. #4327

Closed
wants to merge 1 commit into from

Conversation

topherfangio
Copy link
Contributor

When <md-content> recently added the -webkit-overflow-scrolling: touch
CSS property, the z-index of the bottom sheet was placed into a
separate stacking context and did not respect the z-index of the
scroll mask.

Fix by ensuring the bottom sheets appends the scroll mask to the same
parent as the bottom sheet.

When `<md-content>` recently added the `-webkit-overflow-scrolling: touch`
CSS property, the `z-index` of the bottom sheet was placed into a
separate stacking context and did not respect the `z-index` of the
scroll mask.

Fix by ensuring the bottom sheets appends the scroll mask to the same
parent as the bottom sheet.
@topherfangio topherfangio added the needs: review This PR is waiting on review from the team label Aug 25, 2015
@topherfangio topherfangio added this to the 0.11.0 milestone Aug 25, 2015
@topherfangio topherfangio added pr: merge ready This PR is ready for a caretaker to review and removed needs: review This PR is waiting on review from the team labels Aug 25, 2015
@topherfangio topherfangio changed the title fix(mdBottomSheet): Enable scrolling on touch devices. fix(mdBottomSheet): Enable touch input on mobile devices. Aug 25, 2015
@topherfangio topherfangio changed the title fix(mdBottomSheet): Enable touch input on mobile devices. fix(mdBottomSheet): Enable touch interaction on mobile devices. Aug 25, 2015
@topherfangio topherfangio deleted the fix-bottom-sheet-scrolling branch August 31, 2015 15:45
kennethcachia pushed a commit to kennethcachia/material that referenced this pull request Sep 23, 2015
When `<md-content>` recently added the `-webkit-overflow-scrolling: touch`
CSS property, the `z-index` of the bottom sheet was placed into a
separate stacking context and did not respect the `z-index` of the
scroll mask.

Fix by ensuring the bottom sheets appends the scroll mask to the same
parent as the bottom sheet.

Closes angular#4327.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr: merge ready This PR is ready for a caretaker to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant