This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
fix(mdSelect): Close menu on hitting Enter key #4384
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`checkCloseMenu` is being called without an event in `onMenuKeyDown`, which causes a `Uncaught TypeError: Cannot read property 'currentTarget' of undefined` error. Fixes #4377.
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
|
I signed it (CLA)! 🆗 |
|
CLAs look good, thanks! |
kennethcachia
pushed a commit
to kennethcachia/material
that referenced
this pull request
Sep 23, 2015
call `checkCloseMenu(ev)` with `ev` argument. ensure references to `ev` are non-null Fixes angular#4377. Closes angular#4384.
kennethcachia
pushed a commit
to kennethcachia/material
that referenced
this pull request
Sep 23, 2015
call `checkCloseMenu(ev)` with `ev` argument. ensure references to `ev` are non-null Fixes angular#4377. Closes angular#4384. Closes angular#4372.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
checkCloseMenuis being called without an event inonMenuKeyDown, which causes aUncaught TypeError: Cannot read property 'currentTarget' of undefinederror.Fixes #4377.