Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

contact chips adding an empty object / not filtering already selected contacts #4431

Closed
fxck opened this issue Sep 2, 2015 · 8 comments
Closed
Assignees
Labels
needs: review This PR is waiting on review from the team
Milestone

Comments

@fxck
Copy link

fxck commented Sep 2, 2015

So the first problem, when you go to https://material.angularjs.org/latest/#/demo/material.components.chips and enter something like "foo bar" and press enter, this is going to happen

image

And the second, when "Marina Augustine" is already as a selected contact chip, you can still see her in the suggestions, you are not able to select her, but still.. I'd expect filter-selected to remove her from the list.

Also I'd be nice if you could get the suggestions just by focusing the input, rather than having to input at least one letter..

@fxck
Copy link
Author

fxck commented Sep 2, 2015

The first problem is not necessarily a duplicate of #4404 since I don't as much care about selecting an item from suggestion when pressing enter, as about it creating a new item when no suggestion is found..

@ThomasBurleson ThomasBurleson added this to the 0.12.0 milestone Sep 2, 2015
@topherfangio
Copy link
Contributor

Can you test this out a bit against the master demo: https://material.angularjs.org/HEAD/#/demo/material.components.chips

I know that there have been a few changes to chips recently, and when I type "foo bar" and press enter, nothing happens (because it's not found).

If it still doesn't work as expected, can you please tell us what browser you're using?

@topherfangio topherfangio added the needs: feedback The issue creator or community need to respond to questions in this issue label Sep 2, 2015
@fxck
Copy link
Author

fxck commented Sep 3, 2015

image

this happens on master when I type in "M"

image

this when "foo bar", pressing enter then does nothing indeed, but whether it's because it's bugged or because it was fixed, I don't know

and it's mac / chrome 45

@hkgrani
Copy link

hkgrani commented Sep 3, 2015

I see this behavour as well. Osx and Chrome. It is working on 0.11.0-rc1 but is broken on head/ master

@topherfangio
Copy link
Contributor

@fxck @hkgrani This is a known issue (#4390). The contents of the dropdown are not appearing properly, but the interaction should actually be working (i.e. if you search for nick and hit enter, Nick will be added to the list of chips). We're working to get this resolved.

@hkgrani Are you sure it's working in 0.11.0-rc1? I do not see the dropdown appearing properly there either: https://material.angularjs.org/0.11.0-rc1/#/demo/material.components.chips

We will review this issue again when the dropdown is working to ensure that the issues are fully resolved.

@topherfangio topherfangio added needs: review This PR is waiting on review from the team and removed needs: feedback The issue creator or community need to respond to questions in this issue labels Sep 3, 2015
@hkgrani
Copy link

hkgrani commented Sep 4, 2015

@topherfangio Not shure. I may have tested on a wrong build/ release.
Now 0.11.0-rc1 is gone and the link do not longer work.

@topherfangio
Copy link
Contributor

Might be partially fixed by #5497. Will re-test when that is merged.

@topherfangio
Copy link
Contributor

I believe this is now fixed in HEAD with the exception of the filter-selected attribute which simply isn't implemented and is being tracked in #4131.

Please comment if you are still seeing issues and I will reopen.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs: review This PR is waiting on review from the team
Projects
None yet
Development

No branches or pull requests

4 participants