Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

fix (slider) - fixing slider default value in ng-repeat #479

Closed
wants to merge 1 commit into from

Conversation

sonnylazuardi
Copy link

md-slider does not work within ng-repeat.
when i have used md-slider without ng-repeat the slider sets on its proper position and aria-valuenow is also set with its proper value, but when i have used md-slider within ng-repeat the aria-valuenow="NaN" and slider is not set with its proper position.

Plunker demo of problem - http://plnkr.co/edit/PslB2p?p=preview

With this pull request the default value of md-slider in ng-repeat will be correct.

@ThomasBurleson
Copy link
Contributor

@sonnylazuardi - have you signed a CLA so we can commit your PR?

@sonnylazuardi
Copy link
Author

@ThomasBurleson how to sign a CLA? I have signed here https://cla.developers.google.com/clas

@ThomasBurleson
Copy link
Contributor

@sonnylazuardi
Copy link
Author

@ThomasBurleson so, should I repeat this pull request after signing a CLA?

CLA

@ThomasBurleson
Copy link
Contributor

No... once signed, we can start planning merges of your PRs (as appropriate) into our releases. Thx.

@sonnylazuardi
Copy link
Author

@ThomasBurleson I have signed a CLA in Google Developers. Thank you.

jeffbcross pushed a commit to jeffbcross/material that referenced this pull request Oct 31, 2014
jeffbcross pushed a commit to jeffbcross/material that referenced this pull request Oct 31, 2014
jeffbcross pushed a commit to jeffbcross/material that referenced this pull request Nov 1, 2014
@johnrivelt
Copy link

It still seems not working correctly in my case.
Here is my case from plunker.

https://embed.plnkr.co/FCizUTQnOTzsklhxSIry/

click SSD 1 -> SSD 10 direction set min and value correctly.
But SSD 10 -> SSD 1 backward case, md-slider does not update correctly.
Even min-value is same with valuenow but slider cursor indicate middle of somewhere.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants