This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
Button accessibility fixes #512
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcysutton
force-pushed
the
wip-button-a11y
branch
from
9f746c5 to
30fb910
Compare
|
@ajoslin @ThomasBurleson @rschmukler can someone give this PR a once over? I want to merge it. Pretty minor stuff ahead of a |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few tweaky things for accessibility of buttons, including fixes for incorrect
aria-labelwarnings. Known issues with focus styles: #508 and #142