Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

ng-cloak not working with md-autocomplete #5188

Closed
NicolasBlois opened this issue Oct 15, 2015 · 9 comments
Closed

ng-cloak not working with md-autocomplete #5188

NicolasBlois opened this issue Oct 15, 2015 · 9 comments
Assignees
Milestone

Comments

@NicolasBlois
Copy link

Slow motion gif (it only happens at the first click, to reproduce refresh the page and click again) :
ezgif-3858551348

Normal speed gif :
telechargement

@ThomasBurleson
Copy link
Contributor

Ah HAH! There it is. Thx @blootch. We will investigate...

@robertmesserle
Copy link
Contributor

@kseamon As far as I can tell, this is related to Virtual Repeater. Can you take a look?

@kseamon
Copy link
Contributor

kseamon commented Oct 27, 2015

The repeater does some stuff asynchronously at startup. Is this talking about an autocomplete inside of ng-cloak or row item templates containing ng-cloak?

@robertmesserle
Copy link
Contributor

So basically what happens on the first focus:

  • the DOM element is shown via ng-show
  • the matches array is populated with a list of items to display

However, we see a flicker of the templates showing {{item.display}}

@robertmesserle
Copy link
Contributor

@kseamon Assigning to you for now. Please kick back to me if it isn't fixable within virtual repeater.

@ThomasBurleson ThomasBurleson modified the milestones: 1.0-rc2, 1.0-rc3 Oct 30, 2015
@kseamon kseamon modified the milestones: 1.0-rc4, 1.0-rc3 Nov 5, 2015
@kseamon
Copy link
Contributor

kseamon commented Nov 9, 2015

Looks like this issue A) has nothing to do with ng-cloak, and B) only a bit to do with virtual-repeat.

The real problem is MdAutocompleteItemScopeDirective. Thus far, commenting it out fixes the issue. I'll try to fix it, but do we really even need it @robertmesserle ?

@robertmesserle
Copy link
Contributor

@kseamon I'll sync up with @topherfangio to figure out what we can do about this - I thought I checked that, but apparently I missed something. Reassigning to me.

@kseamon
Copy link
Contributor

kseamon commented Nov 9, 2015

Have a look at #5637

@robertmesserle robertmesserle removed this from the 1.0-rc5 milestone Nov 23, 2015
@kseamon
Copy link
Contributor

kseamon commented Nov 25, 2015

@robertmesserle Any reason for the milestone delay? My PR that fixes this has been pending for a week or two now.

@kseamon kseamon closed this as completed Dec 17, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants