This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
fix(input): calculate icon vertical offset #5732
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThomasBurleson
added
needs: review
|
This is a simple calculation, should be easy to review. @EladBezalel (I hope it's okay if always ask you for reviewing 😄) |
EladBezalel
added
the
needs: manual testing
|
@devversion Np feel free! i would need to test it locally. |
devversion
force-pushed
the
fix/input-icon-alignment
branch
from
6bd7d97 to
db974c0
Compare
|
Update: Rebased to |
|
@devversion it's not aligned accourding the spec, |
EladBezalel
added
needs: work
and removed
needs: manual testing
|
Okay, I will rework that. PS: Thanks for reviewing so much!. Now I have much things to do in the next days 👍 |
|
NP :) |
devversion
force-pushed
the
fix/input-icon-alignment
branch
from
db974c0 to
1ffdbbf
Compare
|
Okay, so now it should use |
devversion
force-pushed
the
fix/input-icon-alignment
branch
3 times, most recently
from
8cb5bfb to
0cf7e7b
Compare
|
Can you please review @EladBezalel |
EladBezalel
added
needs: manual testing
This aligns the icons as prefered in the material specs. Fixes angular#5731
devversion
force-pushed
the
fix/input-icon-alignment
branch
from
0cf7e7b to
5b3311d
Compare
ErinCoughlan
pushed a commit
to ErinCoughlan/material
that referenced
this pull request
Feb 9, 2016
This aligns the icons as prefered in the material specs. Fixes angular#5731. Closes angular#5732.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This centers the icon in the middle as required.
Fixes #5731