Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

fix(list): secondary button wasn't coping ngIf attribute #5991

Closed
wants to merge 1 commit into from
Closed

fix(list): secondary button wasn't coping ngIf attribute #5991

wants to merge 1 commit into from

Conversation

EladBezalel
Copy link
Member

fixes #5297

@EladBezalel EladBezalel added the needs: review This PR is waiting on review from the team label Nov 30, 2015
@ThomasBurleson
Copy link
Contributor

This seems like a micro-patch. What about 'ng-switch, ng-hide, etc?

@ThomasBurleson
Copy link
Contributor

@EladBezalel - Please rebase and confirm CI Travis passes.

@ThomasBurleson ThomasBurleson added pr: merge ready This PR is ready for a caretaker to review and removed needs: review This PR is waiting on review from the team labels Dec 2, 2015
@ThomasBurleson ThomasBurleson added this to the 1.0-rc6 milestone Dec 2, 2015
@ThomasBurleson ThomasBurleson self-assigned this Dec 2, 2015
@EladBezalel
Copy link
Member Author

You're right. But this is the exact issue we discussed about..

@EladBezalel EladBezalel deleted the fix/list-secondary-ng-if branch December 3, 2015 17:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@ThomasBurleson ThomasBurleson

Labels
pr: merge ready This PR is ready for a caretaker to review
Projects
None yet
Milestone
1.0-rc6
Development

Successfully merging this pull request may close these issues.

md-icon / md-list : secondary action cannot be hidden or disabled
2 participants
@EladBezalel @ThomasBurleson