This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
fix(layout): 'flex' change per recommended workarounds #6205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThomasBurleson
force-pushed
the
fix/layout_flex
branch
from
9c35f74
to
2b08f3a
Compare
Per recommended 'flex' settings for Chrome and IE [workarounds](http://philipwalton.com/articles/normalizing-cross-browser-flexbox-bugs/): * use flex === `flex:1 1 0%` instead of `flex:1`. Do not use unitless flex-basis values in the flex shorthand because IE 10-11 will error. * in layout="column" add `flex-shrink:0`. Chrome, Opera, and Safari do not honor the default min-content size of flex items. For column modes, set flex-shrink to 0 (instead of the default 1) to avoid unwanted shrinkage. * add 'flex-nogrow' to symmetrically balance 'flex-noshrink' * fix BottomSheet Grid, Checkbox, Dialog demos with layout.
ThomasBurleson
force-pushed
the
fix/layout_flex
branch
from
2b08f3a
to
33dd0a1
Compare
|
@jelbourn, @topherfangio, @robertmesserle - please review asap! |
|
@ThomasBurleson Hey Thomas, I think you missed, adding the |
Per recommended 'flex' settings for Chrome and IE [workarounds](http://philipwalton.com/articles/normalizing-cross-browser-flexbox-bugs/): * use flex === `flex:1 1 0%` instead of `flex:1`. Do not use unitless flex-basis values in the flex shorthand because IE 10-11 will error. * in layout="column" add `flex-shrink:0`. Chrome, Opera, and Safari do not honor the default min-content size of flex items. For column modes, set flex-shrink to 0 (instead of the default 1) to avoid unwanted shrinkage. * add 'flex-nogrow' to symmetrically balance 'flex-noshrink' * fix BottomSheet Grid, Checkbox, Dialog demos with layout. * fix Dialog Custom demo to use fullscreen for `$mdMedia('xs') || $mdMedia('sm')`
|
@devversion - Nice job. Thank you sir. |
| <fieldset class="standard"> | ||
| <legend>Using <code><input type="checkbox"></code></legend> | ||
| <div layout="row" layout-wrap flex> | ||
| <div ng-repeat="item in items" class="standard" flex="50"> | ||
| <div ng-repeat="item in items" cl ass="standard" flex="50"> |
There was a problem hiding this comment.
You got an extra tab in here or something.
Per recommended 'flex' settings for Chrome and IE [workarounds](http://philipwalton.com/articles/normalizing-cross-browser-flexbox-bugs/): * use flex === `flex:1 1 0%` instead of `flex:1`. Do not use unitless flex-basis values in the flex shorthand because IE 10-11 will error. * in layout="column" add `flex-shrink:0`. Chrome, Opera, and Safari do not honor the default min-content size of flex items. For column modes, set flex-shrink to 0 (instead of the default 1) to avoid unwanted shrinkage. * add 'flex-nogrow' to symmetrically balance 'flex-noshrink' * fix BottomSheet Grid, Checkbox, Dialog demos with layout. * fix Dialog Custom demo to use fullscreen for `$mdMedia('xs') || $mdMedia('sm')`
| .flex, .flex-xs, .flex-gt-xs, .flex-sm, .flex-gt-sm, .flex-md, .flex-gt-md, .flex-lg, .flex-gt-lg, .flex-xl { | ||
| flex: 1 1 0%; | ||
| } | ||
| } |
There was a problem hiding this comment.
@jelbourn - this is intended as an hack for IE-only CSS .
There was a problem hiding this comment.
I still want more info commented on it.
Per recommended 'flex' settings for Chrome and IE [workarounds](http://philipwalton.com/articles/normalizing-cross-browser-flexbox-bugs/): * use flex === `flex:1 1 0%` instead of `flex:1`. Do not use unitless flex-basis values in the flex shorthand because IE 10-11 will error. * in layout="column" add `flex-shrink:0`. Chrome, Opera, and Safari do not honor the default min-content size of flex items. For column modes, set flex-shrink to 0 (instead of the default 1) to avoid unwanted shrinkage. * add 'flex-nogrow' to symmetrically balance 'flex-noshrink' * fix BottomSheet Grid, Checkbox, Dialog demos with layout. * fix Dialog Custom demo to use fullscreen for `$mdMedia('xs') || $mdMedia('sm')`
|
LGTM |
Per recommended 'flex' settings for Chrome and IE [workarounds](http://philipwalton.com/articles/normalizing-cross-browser-flexbox-bugs/): * use flex === `flex:1 1 0%` instead of `flex:1`. Do not use unitless flex-basis values in the flex shorthand because IE 10-11 will error. * in layout="column" add `flex-shrink:0`. Chrome, Opera, and Safari do not honor the default min-content size of flex items. For column modes, set flex-shrink to 0 (instead of the default 1) to avoid unwanted shrinkage. * add 'flex-nogrow' to symmetrically balance 'flex-noshrink' * fix BottomSheet Grid, Checkbox, Dialog demos with layout. * fix Dialog Custom demo to use fullscreen for `$mdMedia('xs') || $mdMedia('sm')`
|
This didn't include the new |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per recommended 'flex' settings for Chrome and IE workarounds:
flex:1 1 0%instead offlex:1. Do not use unitless flex-basis values in the flex shorthand because IE 10-11 will error.flex-shrink:0. Chrome, Opera, and Safari do not honor the default min-content size of flex items. For column modes, set flex-shrink to 0 (instead of the default 1) to avoid unwanted shrinkage.