Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

add flex-wrap attribute for easy access to flex-wrap #634

Closed
wants to merge 1 commit into from

Conversation

EnoF
Copy link
Contributor

@EnoF EnoF commented Nov 13, 2014

I wasn't sure where to add documentation for this. When necessary I can add and amend the commit :)

@Frank3K
Copy link
Contributor

Frank3K commented Nov 13, 2014

I would use this: currently I have made a class for this property in my app's CSS.

I think the change of a pull would be higher if the .gitignore was left out of the commit.

@kpgarrod
Copy link

I would also use this.
On 13 Nov 2014 18:55, "Frank3K" notifications@github.com wrote:

I would use this: currently I have made a class for this property in my
app's CSS.

I think the change of a pull would be higher if the .gitignore was left
out of the commit.


Reply to this email directly or view it on GitHub
#634 (comment).

@ajoslin
Copy link
Contributor

ajoslin commented Nov 15, 2014

I like this change.

Remember, though, you don't need to add the prefixed flex-wrap rules: we add those with autoprefixr in our build.

@EnoF have you signed the google CLA? https://cla.developers.google.com/about/google-individual?csw=1

If you can remove the prefixed rules and verify you've signed the CLA, I'll merge.

@ajoslin ajoslin self-assigned this Nov 15, 2014
@EnoF EnoF force-pushed the flex-wrap branch 3 times, most recently from 0f53bf3 to aad90a5 Compare November 16, 2014 08:25
@EnoF
Copy link
Contributor Author

EnoF commented Nov 16, 2014

@ajoslin I amended the commit to remove the prefixes. I also signed the CLA. However the build is now failing due to:

Error: Cannot find module 'gulp-ng-annotate'

I've debugged a little and the two commits that went wrong are: 12b8cbc and e59a36f. I suspect the merge conflict in this got resolved incorrectly. Missing gulp-ng-annotate dependency in the package.json.

@plato-cambrian
Copy link

I'm gonna get confused about which prefix to use if we have flex, flex-wrap, layout, layout-align, layout-fill, layout-padding

I would unify the names as much as possibly by calling this new rule layout-wrap.
it goes on the container element after all

@ajoslin
Copy link
Contributor

ajoslin commented Nov 17, 2014

@plato-cambrian good point.

Merged with layout-wrap name instead.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants