-
Notifications
You must be signed in to change notification settings - Fork 3.4k
fix(list): show item content separated to the button #6493
Conversation
@@ -5,7 +5,7 @@ a.md-button.md-THEME_NAME-theme, | |||
&:hover { | |||
background-color: '{{background-500-0.2}}'; | |||
} | |||
&.md-focused { | |||
&.md-focused:not(.md-no-focus) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it would be so much clearer if you would just wrap all with
&:not(.md-no-focus)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not getting what you exactly mean. You mean we should wrap that as followed:
&.md-focused {
&:not(md-no-focus) {
background-color: '{{background-500-0.2}}';
}
}
Because I think this will add an empty selector, which is not used. (only &.md-focused
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NVM but i just feel like this is wrong, can't we apply md-focused
only when md-no-focus
is not available?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to be a better a idea, I would prefer a attribute called md-no-focus-style
. See my newest changes, I updated my PR, you should decide about className
or attribute
@devversion in the issue the user claims he can't use 2 checkboxes what is your fix right here? |
I completely reworked the list item structure, in this version we split the button and the content, thats really important because firefox is not allowing by default click events on children. This fix works as same as before, but it only fixes the issues with firefox and other browsers which disallow click events on child nodes |
As you want receive more info, what info is missing?. You can see the Firefox Bug Report on Bugzilla too, https://bugzilla.mozilla.org/show_bug.cgi?id=1181763 |
d4f8031
to
14e70c8
Compare
The code looks much clearer right now. |
14e70c8
to
02dcfb6
Compare
02dcfb6
to
105c7ec
Compare
@ThomasBurleson @EladBezalel I just rebased the PR (due conflicts from 3ffa0a2) and then I combined it with a fix for #6984. Tested it, this will fix the click issues for firefox (https://bugzilla.mozilla.org/show_bug.cgi?id=1181763) and will fix the current button / secondary issue (disconnected button from item content) Here a preview after the fix: |
Fixes angular#6984. Fixes angular#6488. Closes angular#6493.
Hi, http://codepen.io/anon/pen/pgmwBv I believe its for only buttons but what if we want to have non clickable contents like input control ? Thank You |
Yes you're right, as the docs say, it's only restricted for use with buttons. If you would suggest this a feature, you should create another issue. |
Fixes #6984 Fixes #6488