Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

layout options for device type (-phone -tablet -pc) do not work. #682

Closed
ghost opened this issue Nov 18, 2014 · 5 comments
Closed

layout options for device type (-phone -tablet -pc) do not work. #682

ghost opened this issue Nov 18, 2014 · 5 comments
Assignees
Milestone

Comments

@ghost
Copy link

ghost commented Nov 18, 2014

The documentation mentions the following attributes:

  • layout-{phone, tablet, tablet-landscape, pc}
  • {show, hide}-{phone, tablet, tablet-landscape, pc}

The layout options aren't working for me at all.
The show / hide attributes work when {phone, tablet, tablet-landscape, pc} is replaced with {sm, md, lg}.

Either the documentation or the code is incorrect.

I am using 0.5.1 installed from bower in both chrome and firefox.

@ghost
Copy link
Author

ghost commented Nov 18, 2014

Possible duplicate of #224

@Frank3K
Copy link
Contributor

Frank3K commented Nov 18, 2014

The docs reflect the latest version from the master branch. The API has changed today (d51a44c) from {sm, md, lg} to {phone, tablet, tablet-landscape, pc}. You would have to change to the master branch or wait for the new version. Since the API has changed, I suggest the first option.

@gkalpak
Copy link
Member

gkalpak commented Nov 19, 2014

The docs need updating as some of the examples use the old names (-sm, -md, -lg) and some use the new (-phone, -tablet etc).

@ThomasBurleson
Copy link
Contributor

@rschmukler - can you investigate?

@ThomasBurleson ThomasBurleson changed the title Contrary to the docs, options for device size (-sm -md -lg) work, but options for device type (-phone -tablet -pc) do not work. Layout options for device type (-phone -tablet -pc) do not work. Nov 19, 2014
@ThomasBurleson ThomasBurleson changed the title Layout options for device type (-phone -tablet -pc) do not work. layout options for device type (-phone -tablet -pc) do not work. Nov 19, 2014
@rschmukler
Copy link
Contributor

Resolved w/ new layout changes. See the latest docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants