This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
fix(tabs): fixes tab math to address issues when used within dialog #7118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // prevents `offsetWidth` value from being rounded down and causing wrapping issues, but | ||
| // also handles scenarios where `getBoundingClientRect()` is inaccurate (ie. tabs inside | ||
| // of a dialog) | ||
| width += Math.max(element.offsetWidth, element.getBoundingClientRect().width); |
There was a problem hiding this comment.
Are you able to write a unit test that fails without this fix but passes with it?
There was a problem hiding this comment.
I doubt it, it's one of those bugs that only sometimes shows up, but I could give it a shot.
There was a problem hiding this comment.
Actually, it may be doable with this particular one, I think this is more consistent than the other issues related to these calculations.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #7048