Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

fix(list): make dense and normal showcase responsive. #7395

Closed

Conversation

devversion
Copy link
Member

Currently the dense / normal demo won't shrink on mobile screen sizes.
After this commit, the two showcases will wrap on a small screen size.

Also notice, the divider is now splitting the toolbar too, instead of only the content.

FYI:

The diff is really unclear, so I just mention it here, just made the demo root-container using a row layout when bigger than breakpoint -sm, otherwise it uses a column layout.
Created two containers, which flexes to 50% on gt-smdevices, otherwise 100%
So now every container (two containers) contains now one toolbar and the associated content (normal and dense)

@devversion devversion added the needs: review This PR is waiting on review from the team label Mar 3, 2016
Currently the dense / normal demo won't shrink on mobile screen sizes.
After this commit, the two showcases will wrap on a small screen size.

But notice, the divider is now also splitting the toolbar, instead of only the content.
@devversion devversion force-pushed the fix/list-dense-demo-responsive branch from aafa307 to f748e90 Compare March 3, 2016 17:54
@ThomasBurleson
Copy link
Contributor

lgtm

@EladBezalel
Copy link
Member

I didn't want the divider to split the toolbar too but that's nvm.

thanks. lgtm

@EladBezalel EladBezalel added the pr: merge ready This PR is ready for a caretaker to review label Mar 3, 2016
@EladBezalel EladBezalel removed the needs: review This PR is waiting on review from the team label Mar 3, 2016
@devversion
Copy link
Member Author

@EladBezalel Yes, extra mentioned that because it was some kind of a side-effect. Just kept it, because otherwise there would be a much more complex flex layout needed. So I think it still looks fine.

@EladBezalel EladBezalel added needs: manual testing This issue or PR needs to have some manual testing and verification done and removed pr: merge ready This PR is ready for a caretaker to review labels Mar 3, 2016
@devversion devversion deleted the fix/list-dense-demo-responsive branch April 19, 2016 19:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs: manual testing This issue or PR needs to have some manual testing and verification done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants