-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
1 similar comment
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
function loadByDataUrl(url) { | ||
var results = dataUrlRegex.exec(url); | ||
var isBase64 = /base64/i.test(url); | ||
var data = isBase64 ? atob(results[2]) : results[2]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
atob()
is a global; let's use either $window.atob
or window.atob
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
@programmist - nice work! 👍 |
Fixes #4126
This also opens another solution for #6531