Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

Add @ngInject to $mdUtil #7611

Closed
wants to merge 1 commit into from
Closed

Add @ngInject to $mdUtil #7611

wants to merge 1 commit into from

Conversation

mhansen
Copy link
Contributor

@mhansen mhansen commented Mar 17, 2016

Without this, closure compiler renaming breaks injection. #7610

@mhansen
Add @ngInject to $mdUtil
5eec866 
Without this, closure compiler renaming breaks injection.
@crisbeto
Copy link
Member

LGTM 👍

@crisbeto crisbeto added the pr: merge ready This PR is ready for a caretaker to review label Mar 17, 2016
@devversion
Copy link
Member

@crisbeto @mhansen I think it would be better if you combine all these changes into one PR, having four PR's for all the same issue (with one line change) seems for me really weird. Maybe @mhansen can combine all the changes into one. (And the typo you detected @crisbeto)

ThomasBurleson pushed a commit that referenced this pull request Apr 1, 2016
@mhansen @ThomasBurleson
fix(build): closure build needs @ngInject to $mdUtil
284c861 
Without this, closure compiler renaming breaks injection.

*  also needs @ngInject to $mdMedia
*  also needs @ngInject to core.js files.

Closes #7611. Closes #7609. Closes #7608.
ThomasBurleson pushed a commit that referenced this pull request Apr 1, 2016
@mhansen @ThomasBurleson
fix(build): closure build needs @ngInject to $mdUtil
d3c29fe 
Without this, closure compiler renaming breaks injection.

*  also needs @ngInject to $mdMedia
*  also needs @ngInject to core.js files.

Closes #7611. Closes #7609. Closes #7608.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
pr: merge ready This PR is ready for a caretaker to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mhansen @crisbeto @devversion