This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
fix(tabs): not selected tab text color as spec #7920
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
EladBezalel
commented
Apr 6, 2016
EladBezalel
commented
- In da48b6c the color changed from 100 to A100, after checking the spec, the color should be:
|
@devversion - please review. |
|
@EladBezalel I'm running your changes locally and taking a look at some different style configurations. (Grey Primary) But I'm wondering, why you applied those changes only to the |
|
@devversion thank you i didn't think of it |
- In da48b6c the color changed from 100 to A100, after checking the spec, the color should be: > Unfocused tab color: #fff 70% - made the tabs mixin use parameters and simplified usage
EladBezalel
force-pushed
the
fix/tabs-color
branch
from
a296535 to
4e70c1f
Compare
|
@devversion please review |
| @@ -97,25 +51,37 @@ md-tabs.md-THEME_NAME-theme { | |||
| } | |||
| } | |||
|
|
|||
| &.md-accent, &.md-primary, &.md-warn{ | |||
EladBezalel
added
the
in progress
|
Closing. A different solution is needed. |
ilovett
pushed a commit
to ilovett/material
that referenced
this pull request
Apr 22, 2016
- In da48b6c the color changed from 100 to A100, after checking the spec, the color should be: > Unfocused tab color: #fff 70% - made the tabs mixin use parameters and simplified usage Closes angular#7920
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.