Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

Toast always opens at view port height #826

Closed
ericellb opened this issue Dec 2, 2014 · 7 comments
Closed

Toast always opens at view port height #826

ericellb opened this issue Dec 2, 2014 · 7 comments
Assignees
Milestone

Comments

@ericellb
Copy link

ericellb commented Dec 2, 2014

When using mdToast, it will always open at the view port height no matter the vertical size of the application.

This first snapshot is when the page is scrolled all the way up. We can see the toast appear at the bottom of the view.

This second snapshot is when the page is scrolled slightly lower. We can see the toast appearing at the exact same coordinates as it did before. It is no longer showing up at the bottom of the current view.
P.S. The button is fixed in case it is confusing.

It seems like the toast position is being calculated by the height of the viewport and not the height of the browser.

@ThomasBurleson ThomasBurleson added this to the 0.7.0-rc1 milestone Dec 2, 2014
@ericellb
Copy link
Author

ericellb commented Dec 2, 2014

I forgot to mention it when creating the bug report, however the width of the toast is also 100% of the view port when browsing in full screen at 1920x1080.

@gkalpak
Copy link
Member

gkalpak commented Dec 3, 2014

Seems like toasts are absolutely positioned, but they should be fixed instead.

@ericellb
Copy link
Author

ericellb commented Dec 3, 2014

Yes, line 4 in src>components>toast>_toast.scss should be position:fixed;

@epelc
Copy link
Contributor

epelc commented Dec 4, 2014

It would also be nice if we could set the container for toasts like dialogs. Since they overlap any toolbars if you show them on the top.

@ilanbiala
Copy link
Contributor

Any progress on this?

@epelc
Copy link
Contributor

epelc commented Dec 30, 2014

@ilanbiala I just found out $mdToast has a parent attribute like $mdDialog.

I've opened #1067 to add some docs

@rschmukler rschmukler modified the milestones: 0.7.1, 0.7.0 Jan 8, 2015
@naomiblack naomiblack modified the milestones: 0.7.1, 0.8.0 Jan 26, 2015
@rschmukler
Copy link
Contributor

#1106 covers the non #1067 use case of this. Closing as a duplicate.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

7 participants