This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
fix(dialog): remove whitespace from "custom" dialog demo #8271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove extra unnecessary padding from right button that was probably left over by accident. Material Design specifies 8dp (6px) between the right edge of the right-most button and the right edge of the containing dialog. See https://www.google.com/design/spec/components/dialogs.html#dialogs-behavior This was added in b401751 for angular#3135. It should probably have been removed in 3aab9e4.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove extra unnecessary padding from right button that was probably left over by accident.
This was added in b401751 for #3135. It should probably have been removed in 3aab9e4.
Material Design specifies 8dp (6px) between the right edge of the right-most button and the right
edge of the containing dialog.
See https://www.google.com/design/spec/components/dialogs.html#dialogs-behavior
Fixed