Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

autocomplete: clear button does not work in iOS Safari #9764

Closed
donmccurdy opened this issue Oct 5, 2016 · 6 comments
Closed

autocomplete: clear button does not work in iOS Safari #9764

donmccurdy opened this issue Oct 5, 2016 · 6 comments
Assignees
Labels
g3: reported The issue was reported by an internal or external product team. os: iOS This issue is specific to iOS P5: nice to have These issues will not be fixed without community contributions. resolution: fixed type: bug
Milestone

Comments

@donmccurdy
Copy link
Contributor

donmccurdy commented Oct 5, 2016

Actual Behavior:

  • What is the issue? *
    Clicking the mdAutocomplete x in Mobile Safari has no effect.
  • What is the expected behavior?
    Input contents should be cleared.

CodePen (or steps to reproduce the issue): *

Angular Versions: *

  • Angular Version: 1.5.5
  • Angular Material Version: 1.1.1

Additional Information:

  • Browser Type: * Safari
  • Browser Version: * ?
  • OS: * iOS 10.0.2
  • Device: iPhone 6, iPhone 6S
  • Stack Traces:

Shortcut to create a new CodePen Demo.
Note: * indicates required information. Without this information, your issue may be auto-closed.

Do not modify the titles or questions. Simply add your responses to the ends of the questions.
Add more lines if needed.

@devversion devversion self-assigned this Oct 5, 2016
@donmccurdy
Copy link
Contributor Author

donmccurdy commented Oct 6, 2016

Here is a counterexample (source) where it does work in iOS. I'm not sure what the difference is.

(EDIT: fixed link)

@devversion
Copy link
Member

@donmccurdy Thanks. I can reproduce this and I assume this relates to the $mdGesture service.

Probably disabling click hijacking should be a workaround

$mdGestureProvider.skipClickHijack();

@donmccurdy
Copy link
Contributor Author

@devversion thanks, that sounds likely enough but i'm not seeing any effect in my (internal) app, and am not sure how to test the official site's demo. My codepen and gist demos aren't reproducing the issue at all. 😐

@devversion
Copy link
Member

@donmccurdy Just tried it out as well. I can confirm the gesture do not cause the issue.

@devversion devversion added the P5: nice to have These issues will not be fixed without community contributions. label Oct 6, 2016
@ThomasBurleson ThomasBurleson added the g3: reported The issue was reported by an internal or external product team. label Oct 27, 2016
@ThomasBurleson ThomasBurleson added this to the 1.1.3 milestone Oct 27, 2016
@ThomasBurleson ThomasBurleson modified the milestones: 1.1.3, 1.2.0 Jan 1, 2017
@ghost
Copy link

ghost commented May 6, 2017

https://codepen.io/behzadbananmokhtari/pen/PmzyXO
I have fixed this issue (at least temporarily) like this.
Changes are made in JS file. (they are marked with comments)
It also made #9581 problem to go away.

@Splaktar Splaktar changed the title mdAutocomplete clear button does not work in iOS / Safari autocomplete: clear button does not work in iOS Safari Mar 1, 2018
@Splaktar Splaktar added the os: iOS This issue is specific to iOS label Mar 1, 2018
@Splaktar Splaktar modified the milestones: Future, 1.1.9 Mar 1, 2018
@Splaktar Splaktar modified the milestones: 1.1.9, 1.1.10 Apr 19, 2018
@Splaktar Splaktar modified the milestones: 1.1.10, 1.1.11 Jun 19, 2018
@Splaktar Splaktar modified the milestones: 1.1.11, 1.1.12 Sep 10, 2018
@Splaktar Splaktar removed this from the 1.1.12 milestone Jan 3, 2019
@Splaktar Splaktar added this to the 1.1.13 milestone Jan 3, 2019
@Splaktar Splaktar modified the milestones: 1.1.13, 1.1.14 Feb 10, 2019
@Splaktar
Copy link
Contributor

Related to the previous comment, PR #11625 has been posted which should fix #9581.

However, as far as the clear button not working, I am not able to reproduce this on iOS 12.1.4 with AngularJS Material 1.1.12. This issue was reported against iOS 10.0.2 which we no longer support (current browser support).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
g3: reported The issue was reported by an internal or external product team. os: iOS This issue is specific to iOS P5: nice to have These issues will not be fixed without community contributions. resolution: fixed type: bug
Projects
None yet
Development

No branches or pull requests

5 participants