fix(focus-monitor): reenter ngzone before emitting #10549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmalerba
added
pr: needs review
target: patch
googlebot
added
the
cla: yes
crisbeto
reviewed
Mar 25, 2018
| expect(buttonElement.innerText).toBe(''); | ||
| buttonElement.focus(); | ||
| fixture.detectChanges(); | ||
| expect(buttonElement.innerText).toBe('program'); |
There was a problem hiding this comment.
Rather than having the test go through change detection, you should be able to assert the same using NgZone:
const spy = jasmine.createSpy('zone spy');
focusMonitor.monitor(element).subscribe(() => {
spy(NgZone.isInAngularZone());
});
expect(spy).toHaveBeenCalledWith(true);There was a problem hiding this comment.
neat, didn't know that method existed
jelbourn
added
pr: lgtm
action: merge
andrewseguin
added
the
presubmit failures
mmalerba
removed
the
presubmit failures
|
@andrewseguin I think we can just approve the screen diffs |
josephperrott
pushed a commit
that referenced
this pull request
May 4, 2018
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.