fix(datepicker): dateInput event being fired if the value hasn't changed #10952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
mmalerba
approved these changes
Apr 23, 2018
mmalerba
added
pr: lgtm
action: merge
andrewseguin
added
the
presubmit failures
jelbourn
removed
action: merge
|
This passes google presubmit but looks like it's failing on Travis |
Fixes the `dateInput` event being fired even if the value hasn't changed. This can happen if the browser fires the `input` event while the value hasn't changed (e.g. if the user marks a character and "replaces" it with the same character).
crisbeto
force-pushed
the
dateinput-event-multiple
branch
from
4c40a5b to
8125b15
Compare
|
I've sorted out the test failures @jelbourn. |
jelbourn
pushed a commit
to jelbourn/components
that referenced
this pull request
May 14, 2018
…ged (angular#10952) Fixes the `dateInput` event being fired even if the value hasn't changed. This can happen if the browser fires the `input` event while the value hasn't changed (e.g. if the user marks a character and "replaces" it with the same character).
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the
dateInputevent being fired even if the value hasn't changed. This can happen if the browser fires theinputevent while the value hasn't changed (e.g. if the user marks a character and "replaces" it with the same character).