Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tabs): don't show focus indication for mouse focus #11194

Merged

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented May 6, 2018

Similarly to other components, makes the tabs focus indication not to show for mouse focus.

Fixes #11184.

Similarly to other components, makes the tabs focus indication not to show for mouse focus.

Fixes angular#11184.
@crisbeto crisbeto requested a review from andrewseguin as a code owner May 6, 2018 20:24
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 6, 2018
@andrewseguin andrewseguin added pr: lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels May 29, 2018
@ngbot
Copy link

ngbot bot commented May 29, 2018

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "continuous-integration/travis-ci/pr" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@mmalerba mmalerba merged commit 89cad3f into angular:master Jul 3, 2018
mmalerba pushed a commit that referenced this pull request Jul 9, 2018
Similarly to other components, makes the tabs focus indication not to show for mouse focus.

Fixes #11184.
victoriaaa234 pushed a commit that referenced this pull request Jul 25, 2018
Similarly to other components, makes the tabs focus indication not to show for mouse focus.

Fixes #11184.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Tabs] background from :focus pseudoselector is visible until the next click anywhere
5 participants