Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ripple): disable ripple animations when using NoopAnimationsModule #11205

Merged
merged 1 commit into from
May 10, 2018
Merged

fix(ripple): disable ripple animations when using NoopAnimationsModule #11205

merged 1 commit into from
May 10, 2018

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented May 7, 2018

Disables the ripples animations when the consumer is using the NoopAnimationsModule.

@crisbeto crisbeto requested a review from devversion as a code owner May 7, 2018 15:31
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 7, 2018
josephperrott
josephperrott reviewed May 7, 2018
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a test about this? I am not sure how we could do it, but is it possible?

@crisbeto
fix(ripple): disable ripple animations when using NoopAnimationsModule
dd45146 
Disables the ripples animations when the consumer is using the `NoopAnimationsModule`.
@crisbeto crisbeto force-pushed the ripple-disable-animations branch from dfbf3a5 to dd45146 Compare May 7, 2018 15:46
@crisbeto
Copy link
Member Author

crisbeto commented May 7, 2018

Just pushed them @josephperrott.

josephperrott
josephperrott approved these changes May 7, 2018
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephperrott josephperrott added pr: lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release and removed pr: needs review labels May 7, 2018
@ngbot
Copy link

ngbot bot commented May 7, 2018

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "continuous-integration/travis-ci/pr" is failing
    pending 1 pending code review

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

jelbourn
jelbourn approved these changes May 7, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephperrott
Copy link
Member

Continues work on #10590

crisbeto added a commit to crisbeto/material2 that referenced this pull request May 9, 2018
@crisbeto
fix(checkbox): disable animations when using NoopAnimationsModule
d7da2ab 
* Disables all checkbox animations when using the `NoopAnimationsModule`. Doesn't include ripples which were done in angular#11205.
* Removes a method that was only used once and inlines the logic.
@crisbeto crisbeto mentioned this pull request May 9, 2018
Merged
@jelbourn jelbourn removed the request for review from devversion May 10, 2018 15:47
@jelbourn jelbourn merged commit 9715928 into angular:master May 10, 2018
jelbourn pushed a commit to jelbourn/components that referenced this pull request May 14, 2018
@crisbeto @jelbourn
fix(ripple): disable ripple animations when using NoopAnimationsModule (
29d7330 
angular#11205)

Disables the ripples animations when the consumer is using the `NoopAnimationsModule`.
tinayuangao pushed a commit that referenced this pull request May 15, 2018
@crisbeto @tinayuangao
fix(checkbox): disable animations when using NoopAnimationsModule (#1…
93b5892 
…1249)

* Disables all checkbox animations when using the `NoopAnimationsModule`. Doesn't include ripples which were done in #11205.
* Removes a method that was only used once and inlines the logic.
tinayuangao pushed a commit that referenced this pull request May 15, 2018
@crisbeto @tinayuangao
fix(checkbox): disable animations when using NoopAnimationsModule (#1…
6515d9c 
…1249)

* Disables all checkbox animations when using the `NoopAnimationsModule`. Doesn't include ripples which were done in #11205.
* Removes a method that was only used once and inlines the logic.
devversion added a commit to devversion/material2 that referenced this pull request Jun 24, 2018
@devversion
docs(ripple): add note about NoopAnimationsModule
0c2f772 
* Adds a small note about the `NoopAnimationsModule` to the ripple animation config.
* Moves the form-fields in the toolbar demos into a different toolbar demo (separated; for a cleaner demo-app)

References angular#11205
@devversion devversion mentioned this pull request Jun 24, 2018
Merged
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@josephperrott josephperrott josephperrott approved these changes

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

@devversion devversion

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@crisbeto @josephperrott @jelbourn @devversion @googlebot