-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(checkbox): disable animations when using NoopAnimationsModule #11249
fix(checkbox): disable animations when using NoopAnimationsModule #11249
Conversation
* Disables all checkbox animations when using the `NoopAnimationsModule`. Doesn't include ripples which were done in angular#11205. * Removes a method that was only used once and inlines the logic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Addresses #10590 |
Changed target to |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
NoopAnimationsModule
. Doesn't include ripples which were done in fix(ripple): disable ripple animations when using NoopAnimationsModule #11205.