Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(checkbox): disable animations when using NoopAnimationsModule #11249

Merged
merged 1 commit into from
May 15, 2018

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented May 9, 2018

* Disables all checkbox animations when using the `NoopAnimationsModule`. Doesn't include ripples which were done in angular#11205.
* Removes a method that was only used once and inlines the logic.
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 9, 2018
Copy link
Contributor

@tinayuangao tinayuangao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tinayuangao tinayuangao added target: patch This PR is targeted for the next patch release pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels May 10, 2018
@ngbot
Copy link

ngbot bot commented May 10, 2018

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "branch manager" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@josephperrott josephperrott removed the request for review from devversion May 14, 2018 22:37
@josephperrott
Copy link
Member

Addresses #10590

@tinayuangao tinayuangao merged commit 93b5892 into angular:master May 15, 2018
tinayuangao pushed a commit that referenced this pull request May 15, 2018
…1249)

* Disables all checkbox animations when using the `NoopAnimationsModule`. Doesn't include ripples which were done in #11205.
* Removes a method that was only used once and inlines the logic.
@tinayuangao tinayuangao added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels May 15, 2018
@tinayuangao
Copy link
Contributor

Changed target to minor since noop animation css PR is marked as "target:minor"

tinayuangao added a commit that referenced this pull request May 15, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants