fix(dialog,bottom-sheet): don't provide directionality if no direction is set #11285
Conversation
crisbeto
requested review from
jelbourn,
josephperrott and
mmalerba
as code owners
googlebot
added
the
cla: yes
mmalerba
added
pr: lgtm
action: merge
|
I see that you just added the If you want your PR to be merged, it has to pass all the CI checks. If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help. |
|
Hi @crisbeto! This PR has merge conflicts due to recent upstream merges. |
jelbourn
added
pr: needs rebase
and removed
action: merge
…n is set * Currently the dialog and bottom sheet always provide the `Directionality` in order to allow for any components placed inside of them to pick up their direction. This is problematic if the consumer didn't set a direction, because the `value` of the provided `Directionality` will be set to `undefined`. These changes switch to only providing the direction if it is defined in the config, otherwise the components will fall back to the global `Directionality`. * Flips around some logic in the drawer so an undefined direction is consider `ltr`, rather than `rtl`. Fixes angular#11262.
crisbeto
force-pushed
the
11262/dialog-undefined-dir
branch
from
ef5bac9 to
01ea799
Compare
crisbeto
added
action: merge
|
I see that you just added the If you want your PR to be merged, it has to pass all the CI checks. If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help. |
…n is set (#11285) * Currently the dialog and bottom sheet always provide the `Directionality` in order to allow for any components placed inside of them to pick up their direction. This is problematic if the consumer didn't set a direction, because the `value` of the provided `Directionality` will be set to `undefined`. These changes switch to only providing the direction if it is defined in the config, otherwise the components will fall back to the global `Directionality`. * Flips around some logic in the drawer so an undefined direction is consider `ltr`, rather than `rtl`. Fixes #11262.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Directionalityin order to allow for any components placed inside of them to pick up their direction. This is problematic if the consumer didn't set a direction, because thevalueof the providedDirectionalitywill be set toundefined. These changes switch to only providing the direction if it is defined in the config, otherwise the components will fall back to the globalDirectionality.ltr, rather thanrtl.Fixes #11262.